Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced RF Storage Only Providing the Power of a Regular RF Storage #15

Closed
droidix opened this issue Jun 25, 2018 · 3 comments
Closed

Comments

@droidix
Copy link

droidix commented Jun 25, 2018

Advanced RF Storage blocks are only providing the power of regular RF Storage blocks during the crafting operation. For example, in Continuum, the ME Controller requires 2,000 RF/t, but the crafting operation immediately stops after clicking start and the EFab monitor flashes "error". This is when using two Advanced RF Storage blocks (configured at 1,000 RF/t each). However, eight regular RF Storage blocks work fine (configured at 250 RF/t each).

The resolution of issue #12 fixed the initial error before you could even begin the crafting operation. This new issue appears to be caused by this line:

stillneeded = handlePowerPerTick(stillneeded, this.rfStorages, GeneralConfiguration.rfStorageInternalFlow);

Each RF Storage is being capped at the configured value of a regular RF Storage instead of determining the type of RF Storage and using its configured amount.

Mod version: efab-0.1.0

@lurch9229
Copy link

I have a similar issue where the efab doesn't even recognise the advanced rf storage, therefore 1000rf/t for dragging just by making an advanced block, any work rounds other than putting them aside and making more tier 1 storge

@McJty
Copy link
Collaborator

McJty commented Jul 7, 2018

I will try to check this out soon

mjevans added a commit to mjevans/EFab that referenced this issue Aug 5, 2018
 (advanced, but string sortable/better self documenting)

This should resolve the following bug reports:
 McJtyMods#15
 FTBTeam/FTB-Continuum#330

As a side note, I believe the state per block multiblock design
is a mistake.  It does not scale up well and probably causes
many TE updates to occur per tick.

NOTE: Untested as the changes are minimal and setting up a build env seems daunting.

Legal:
If possible I disclaim any copyright to the code I am contributing.
I do not believe this input to be sufficient work to constitute a new copywritten work.
If the above is not possible, I assign any copyright claims for my contribution under
dual-license as both CC0 and a perpetual grant of full-non-exclusive rights to any developer of this mod.
@McJty
Copy link
Collaborator

McJty commented Sep 12, 2018

Fixed next release

@McJty McJty closed this as completed Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants