Created new Metadata provider for TheMovieDB: MovieDbEpisodeProvider #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the required logic already existed in MovieDbEpisodeImageProvider. In order to avoid duplicated code, I have moved all common code to a new base class "MovieDbProviderBase" from which MovieDbEpisodeProvider and MovieDbEpisodeImageProvider are inheriting now.
|
I used the unspecific name "MovieDbProviderBase" for the base class, because it could also serve as a base for MovieDbSeasonProvider, MovieDbSeriesProvider and MovieDbSeriesImageProvider in the future. There is still a lot of duplicate code. |
Ensures that the new provider is disabled by default
|
I just added the same kind of migration task as I did for the OmdbEpisodeProvider. Regarding query performance I would like to note that the new provider is less critical than the OmdbEpisodeProvider because it caches its results to disk (same like TvdbEpisodeProvider). |
LukePulverenti
added a commit
that referenced
this pull request
Mar 3, 2016
Created new Metadata provider for TheMovieDB: MovieDbEpisodeProvider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the required logic already existed in MovieDbEpisodeImageProvider.
In order to avoid duplicated code, I have moved all common code to a new base class "MovieDbProviderBase" from which MovieDbEpisodeProvider and
MovieDbEpisodeImageProvider are inheriting now.