Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figma link 🥳 #56

Merged
merged 35 commits into from
Nov 8, 2022
Merged

Figma link 🥳 #56

merged 35 commits into from
Nov 8, 2022

Conversation

GaspardC
Copy link
Collaborator

@GaspardC GaspardC commented Nov 3, 2022

Link generated by the plugin Figma

Screenshot 2022-11-03 at 19 14 58

The svg is fetched from the params in url

Screenshot 2022-11-04 at 16 55 25

Done :

  • import svg from params in url (by default for testing an image is loaded at http://localhost:3000/bytesim-webapp/figma)
  • extract zones from id in svg
  • create the arborescence tree
  • display the tree in the left panel
  • hover from the panel highlight the zone
  • hide/show some tree node
  • reset all reset figma zone to init position
  • keep main zones data between refresh
  • fix zoom merge with fetched svg
  • commented out vanilla zone highlight

Need to be done :

  • link new store zone with recommendations engine
  • merge figma reducer into exisitng zone reducer
  • implement svg id to image

@GaspardC GaspardC changed the title Figma link Figma link [WIP] Nov 4, 2022
@GaspardC GaspardC changed the title Figma link [WIP] Figma link 🥳 Nov 4, 2022
package.json Show resolved Hide resolved
src/components/zones/ZonesList.tsx Outdated Show resolved Hide resolved
src/features/figma/components/FetchedSVG.tsx Outdated Show resolved Hide resolved
src/services/conts.ts Outdated Show resolved Hide resolved
@slecorne slecorne merged commit 3c08333 into master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants