Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect generation of WebSockets-Secret in Client Handshake #1

Closed
samsharp99 opened this issue Nov 28, 2019 · 0 comments
Closed

Fix incorrect generation of WebSockets-Secret in Client Handshake #1

samsharp99 opened this issue Nov 28, 2019 · 0 comments
Assignees
@samsharp99
Labels
bug Something isn't working
Projects
LabVIEW WebSockets API

Comments

@samsharp99
Copy link
Contributor

There is a bug in the generation of the WebSockets-Secret where the secret is not correctly Base64 encoded which leads to issues when communicating with 3rd-party WebSockets servers (e.g. Python).
@samsharp99 samsharp99 added the bug Something isn't working label Nov 28, 2019
@samsharp99 samsharp99 self-assigned this Nov 28, 2019
@samsharp99 samsharp99 added this to To do in LabVIEW WebSockets API via automation Nov 28, 2019
samsharp99 added a commit that referenced this issue Nov 30, 2019
@samsharp99
- Fix issue #1 (Incorrect generation of Sec-WebSockets-Key in Client …
c26ab1e 
…Handshake). Updated to generate 16 random bytes and Base64 encode as per RFC 6455.
LabVIEW WebSockets API automation moved this from To do to Done Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samsharp99 samsharp99

Labels
bug Something isn't working
Projects
LabVIEW WebSockets API
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samsharp99