Fix all the things #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparing for the postcss update. Note: - Keytar is intentionally pinned to 7.6.0 due to an electron-builder bug that makes 7.7.0 not work. atom/node-keytar#380 electron-userland/electron-builder#5438
Mostly preparing to get rid of unsupported and vulnerable PostCSS 7. Notes: - This requires a lot of beta versions for Vue-related packages. Non-beta versions tend to depend on PostCSS 7. - PostCSS 7 is still not eliminated entirely as one of the Vue packages still requires 7. - The babel-eslint package is deprecated, but can't be upgraded to the non-deprecated @babel/eslint-parser package, otherwise the standard build process would be broken. - The change in the SVG icon component was needed to make SVG icons display again. Not sure why this happened. - It seems Electron 13 can't be used due to no support from Keytar.
This silently overwrote and/or added to old settings. Now it's a validation error.
That makes the fields much more clearly separated. Closes: MediaWikiAGE#64
Currently just the Escape key is handled to close the modal. Closes: MediaWikiAGE#63
This gets rid of the PostCSS security alert. Unfortunately, two new and unrelated vulnerabilities were reported in other indirect dependencies two days ago. Closes: MediaWikiAGE#66
The actual view still has some issues.
and adjust the lightness slightly. This should also fit both light and dark themes (somewhat).
Add focus indicators, fix elements that shouldn't be focusable, fix the "no input" zone of "Enabled?" checkboxes, and extract the "deferred focus" hack into its own method. Sigh. Closes: MediaWikiAGE#59
That added one iteration to the loop = extra 50 milliseconds of waiting. Improves switching times when the conditionally-rendered element is absent from the DOM entirely (read: `v-if`).
Like with the changes to the login menu.
Like with the tasks view. Also de-cluttered the HTML by using `@apply` in a `<style>` rather than specifying all utilities inline.
Why didn't anyone do this before?
Simplifies style testing. Closes: MediaWikiAGE#61
This should actually be not just a major usability issue, but a critical matter of communicating state to other components.
Otherwise this will print errors about accessing the `accounts` property of `undefined`.
This does not persist actual task process. This will have to be handled very, very differently, and I'm not sure how yet. Closes: MediaWikiAGE#53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, maybe not all of everything, but I did do a lot. Hopefully not too much.