add method for adding synthetic fields to messages #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| MessageDescriptor.prototype.addSyntheticField = function (type, name, tag) { | ||
| return this.addField(new FieldDescriptor(type, name, tag)) | ||
| } |
There was a problem hiding this comment.
an alternative I decided against:
add FieldDescriptor to the module exports so clients could create their own and use the existing addField(...).
That seemed like a big abstraction leak for little gain; plus, adding synthetic fields shouldn't be ordinary, so an explicit method seemed like a nice way to make that clear.
|
lgtm i'm not sure i would have done this by modifying the proto model, but ok |
dmccartney
added a commit
that referenced
this pull request
Dec 7, 2015
add method for adding synthetic fields to messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @nicks, @koop,
Please review the following commits I made in branch 'daniel-synth-field'.
1cda2ff (2015-12-04 23:37:20 -0800)
add method for adding synthetic fields to messages
R=@nicks
R=@koop