Fix for wrong bot chase behavior #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's hold off on this until I make the unit tests pass. |
|
Ok, unit tests are working now, but I'm going to wait until the gradle branch gets merged in to make that PR. |
sixlettervariables
approved these changes
Aug 16, 2018
neoancient
requested changes
Aug 16, 2018
Merged
|
Ok. Put up a separate PR with just the unit test changes cherry-picked. |
NickAragua
added a commit
that referenced
this pull request
Aug 21, 2018
unit test fixes for PR #1100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bot behavior that's been annoying me for quite a while. Normally, bot units under "forced withdrawal" don't fire until fired upon, but, when the bot is under "immediate withdrawal" rules, that goes out the window.
Best way to test this is to give the bot a tank of some kind, yourself a unit with a lot of low damage/clustering weapons (SRMs, small lasers, MGs). Set 'forced withdrawal' to on and give the bot a 'destination edge'.
The expected behavior is that it'll shoot at you normally. When you cripple it (armor breach, immobilized, etc), it should not shoot at you the following round.
If you shoot or kick it subsequently, it should return fire on the following round.