Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2722: Do not send IP addresses in chat by default #2725

Conversation

sixlettervariables
Copy link
Collaborator

This PR does two things w.r.t. IP addresses:

  1. Ensures they are all logged (server IP and port and client IPs)
  2. Ensures they are not sent in chat publicly by default

Resolves #2722

I've tried to keep this as simple as possible so it is stable backport compatible.

@sixlettervariables
Copy link
Collaborator Author

UI will be a separate PR.

@sixlettervariables
Copy link
Collaborator Author

New default behavior:
image
image

Updating my preferences to show IPs:
image
image

@sixlettervariables sixlettervariables merged commit 939ee95 into MegaMek:master Mar 18, 2021
@sixlettervariables sixlettervariables deleted the issue-2722-hide-ip-addresses branch March 18, 2021 16:11
@sixlettervariables sixlettervariables added the Stable Backport Candidate This PR is a candidate to be backported to the Stable branch label Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Security Stable Backport Candidate This PR is a candidate to be backported to the Stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: Means of hiding IP in client chat box
2 participants