unit tool tip updates #4078
unit tool tip updates #4078
Conversation
kuronekochomusuke
added
(RFE) Enhancement
Codecov ReportBase: 23.02% // Head: 22.99% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4078 +/- ##
============================================
- Coverage 23.02% 22.99% -0.03%
Complexity 4816 4816
============================================
Files 2275 2275
Lines 249526 249819 +293
Branches 46286 46335 +49
============================================
+ Hits 57443 57446 +3
- Misses 190631 190921 +290
Partials 1452 1452
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
These look great. |
|
Posted a teaser on the forums. There was a request any chance of Bomb count and type on aircraft (and potentially VTOLs) would be great as well, seeing as there's no way of telling that in-game. |
|
which VTOL has bombs? tried searching for one with a bomb bay, but did not find any.
|
|
Seem to recall VTOL bomb is an optional rule. So if you enabled it and loaded up a VTOL that it would show. |
|
turning on TacOps VTOL Special Attacks allowed bombs to be added
|
|
That’s a huge improvement. Do we show what’s being carried? I.e. Dropship showing units and doors, warships shows dropships and fighters |
|
it already show that
|
|
Cool. It wondered if it did but not near my computer to check. |
|
Had a couple of comments on the forums.
Should we support the message with unofficial unjam UAC?
Not sure about support around optional rules, but I think it would make sense to cover all the edge cases. |
|
the button is Unjam RAC also are there any weapons that can jam that don't get unjammed when the unofficial setting is used:? could change the to just descriptions unjam/unjamming, if it unjams all weapon types when the unofficial setting is used. |
I'm a fan anything that simplifies the process and makes things clearer. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
|
|
|
|
|
This looks great. However, I'm confused by what the part behind movement is showing. Maybe I'm just dense :) |
|
Concerning the bombers it should be possible to do if (entity instanceof IBomber) and then cast to (IBomber) and use .getBombChoices() on that (all bomb-capable entity classes implement IBomber). |
|
the symbols after the movement are an indicator as to why the movement is lower. should probably make a key, since some may not be easy to interpret |
|
should LandAirMech movement be reduced by bomb load like the other IBomber units? should QuadMech movement be reduced by shields like BipedMech and TripodMech units? |
|
Request: is it possible to add unit facing to the tooltip? It's essentially impossible to determine unit facing if there is more than one unit in a single hex, but a tooltip readout would make it unambiguous. |
|
|
|
this is ready for review |
| } else { | ||
| result.append("<BR>"); | ||
| } | ||
| } | ||
| result.append("\n"); |
There was a problem hiding this comment.
just makes it easier to see if i did things correctly, can remove if needed
update the unit tool tip with addition information
🔥= heat
☂ = planetary conditions
🔧= damage
💣= bomb load
⛨ = shields
⟬▮ = modular armor