Read/Write AS/SBF units #5249
Merged
Read/Write AS/SBF units #5249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # megamek/src/megamek/common/alphaStrike/AlphaStrikeElement.java # megamek/src/megamek/common/strategicBattleSystems/SBFFormation.java
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability write and read AS elements and SBF formations and units to/from YAML-formatted files (that are similar to MTF but not a custom format and nice to read and edit). I called them MMU files to separate them from the unfortunate naming coincidence of "MUL". Current gameplay is not affected. The intended veeery long-term use is to be able to read in such units for use e.g. in scenarios. Scenarios allow bypassing the lobby and thus may make it slightly easier to add SBF game support (again, very long-term or maybe never, who knows).
It uses Jackson (a dependency we already have) with an added library for YAML. The main part of the changes are the custom serializers/deserializers which required a few small changes in the unit classes, MMUWriter and MMUReader, a few parsing additions in AS-related classes as well as some formatting examples.