Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nag and turn timer updates #5254

Merged
merged 7 commits into from Mar 20, 2024
Merged

nag and turn timer updates #5254

merged 7 commits into from Mar 20, 2024

Conversation

kuronekochomusuke
Copy link
Collaborator

@kuronekochomusuke kuronekochomusuke commented Mar 16, 2024 •
edited

  • correct issue when turn timer expires causes skip button to not show on status bar
  • when turn timer expires skip all nags
  • add missing nags to client settings
  • add null checks for when nag is active and turn timer expires
  • bind escape to close action for nag popups

image

fixes #5242

@kuronekochomusuke kuronekochomusuke marked this pull request as draft March 16, 2024 16:02
@kuronekochomusuke kuronekochomusuke marked this pull request as ready for review March 16, 2024 22:16
@SJuliez SJuliez merged commit 94f44c7 into MegaMek:master Mar 20, 2024
4 checks passed
@kuronekochomusuke kuronekochomusuke deleted the nagsTurnTimerUpdates branch April 20, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SJuliez SJuliez SJuliez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[0.49.18] Turn timer removes "skip firing" button
2 participants
@kuronekochomusuke @SJuliez