Improved Initial Log Message #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SJuliez
approved these changes
Jan 29, 2022
There was a problem hiding this comment.
Seeing the project_name constant I was wondering if there is a way to have static access to which program is the main program running right now (so MML in MHQ could still know that this is MHQ running and would know if it's standalone MML). Is there a direct way to this or can we implement a SuiteConstants "constant" that is set to MM/MML/MHQ in the respective main()?
|
That's my next goal for the suite changes, namely as part of standardizing the about dialogs. I wanted to handle the logging improvements to make debugging logs easier faster, but that's the goal for the whole design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the MML implementation for MegaMek/megamek#3412