Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing BuildView createLabel Missing Tooltips #1079

Merged
merged 6 commits into from
Mar 31, 2022
Merged

Fixing BuildView createLabel Missing Tooltips #1079

merged 6 commits into from
Mar 31, 2022

Conversation

Windchild292
Copy link
Member

For Review:
The first commit is a refactor, the second removes some useless setEditable calls, the third adds tooltips to a bunch of labels that should have had them already.

@Windchild292 Windchild292 added Bug Enhancement GUI User-interface related issue labels Mar 28, 2022
@Windchild292 Windchild292 self-assigned this Mar 28, 2022
SJuliez
SJuliez approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@SJuliez SJuliez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the labels had no TT, the text fields/combos did have them. But there's no disadvantage to labels also having TTs.

@Windchild292 Windchild292 merged commit 6868687 into MegaMek:master Mar 31, 2022
@Windchild292 Windchild292 deleted the dev_Windchild_BasicInfoViewBugs branch March 31, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SJuliez SJuliez SJuliez approved these changes

Assignees

@Windchild292 Windchild292

Labels
Bug Enhancement GUI User-interface related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Windchild292 @SJuliez