Embedded fonts #130
Merged
Embedded fonts #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added fill as xml attribute in text elements where batik was not using the CSS value.
Changed font measuring to use FontMetrics instead of adding a new element and measuring the bounding box.
There can be a problem rendering a PNG that I traced down to an array index out of range while copying the raster data but could find no way to head it off. So far it's just one image that I encountered this with.
equipment inventory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches mech printing from svgSalamander to Apache's Batik. Embedded font support in svgSalamander is broken and fixing it would be non-trivial. The one advantage of svgSalamander is its small size, but Batik has better support and documentation and supports features not found in svgSalamander.
Currently both libraries are present, since non-mech printing is still using svgSalamander. Once the remaining record sheets are transitioned to the new approach we can remove the older library.