-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vehicle Record Sheet Overhaul #398
Conversation
Optimized for more regular regions, such as used by vehicles and aerospace units.
Show supercharger and vjj on equipment list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two comments. The new SVGs look great.
@@ -0,0 +1,1495 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I normally wouldn't review these by hand, but the files are formatted quite bizarrely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they're built in memory using DOM then written to a file using Batik's SVGGraphics2D#stream. I haven't found a way to influence the formatting of the output, but I haven't spent a lot of time looking.
Implements the SVG template-based printing method currently used for 'Mechs, conventional infantry, and JS/WS/SS. Some things worth particular note:
Here is a sample of the results. There are a few at the end that are not fully constructed units but show what the sheets look like for naval/WiGE dual turrets and superheavy naval combat vehicles, none of which are represented in the units in MM:
Skulker_Wheeled_Scout_Tank__Standard__etc__ated_files-job_1193.pdf
Fixes #42