-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large craft rs #491
Merged
Merged
Large craft rs #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also distinguish between fore and aft for spheroid, or forward and rear for wings.
…ap the name text.
…raft inventory blocks.
Made adjustments in armor block placement.
Added a gap between blocks.
Also distinguish between fore and aft for spheroid, or forward and rear for wings.
…ap the name text.
…raft inventory blocks.
Made adjustments in armor block placement.
Added a gap between blocks.
neoancient
commented
Feb 23, 2020
sixlettervariables
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second half of the aerospace record sheet overhaul. Some notes about changes:
Breaks up the older PrintCapitalShip, which previously was a subclass of PrintEntity, into PrintDropship, which subclasses PrintAero, and PrintCapitalShip, which subclasses PrintDropship. PrintDropship has the code that is common to all large craft, particulary involving sorting out the various blocks of text in the inventory panel and making sure the font is scaled appropriately to fit everything. PrintCapitalShip is responsible for drawing the armor and internals blocks, which are done in 10x10 grids rather than circular pips.
Removed some code that is not used, including merging identical fore and aft weapon bays into a single line, and allowing for the possibility of vertical alignment of JS/WS/SS internal pip blocks.
Moved non-weapon equipment from a table that is designed to display weapons to a block of text at the bottom of the inventory panel.
Fixed a problem that causes jumpship aft armor on top of the ship outline.
Samples:
Leopard__3056__etc-job_1283.pdf