Infantry Record Sheet rework #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sixlettervariables
approved these changes
Mar 29, 2020
| || infantry.getMovementMode() == EntityMovementMode.SUBMARINE; | ||
| hideElement(UW_LABEL, !scuba); | ||
| InfantryWeapon singleSecondary = (infantry.getSecondaryN() == 1)? infantry.getSecondaryWeapon() : null; | ||
| for (int j = 0; j <= 21; j++) { |
There was a problem hiding this comment.
The soldiers themselves are 1-based and ranges are 0-based?
There was a problem hiding this comment.
Yes, which could be a little confusing but it coincides with the text label. The soldiers and numbered 1-30 and the range table headers start at zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves conventional infantry record sheet printing to the new framework, using Batik as the SVG library instead of svgSalamander. We are currently distributing with a custom build of svgSalamander that has some fixes to text layout, but with the infantry record sheets no longer using it, the release is good enough for loading the SVG images still used by ProtoMechs and BattleArmor.
The infantry sheets use two new classes in the printing package. PrintSmallUnitSheet is responsible for the overall page, including the header and footer. It uses PrintInfantry for each platoon or point up to four per page. The same class will also handle individual BA points/squads and protomechs as those sheets get redesigned.
Sample:
Foot_Platoon__MG__etc__sing_non-Linux-generated_files-job_1315.pdf