-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crit unification #971
Crit unification #971
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things first, mostly just naming conventions.
The code looks great, and is a huge reduction in complexity.
All in. We could kinda come up with an agreement on using ProtoMek or ProtoMech in the code ;) |
I think we should stick with the Mek as opposed to Mech in general. |
OK so let's make it ProtoMek (including the Capital) from now on. |
Do you plan on swapping the ones here as part of this PR @SJuliez? |
Nah. I'll do it as I go along. |
Adds a CritCellUtil class that combines general Crit Cell display functionality. Lots of code cleanup without much visual effect. Especially in the various CriticalView classes loads of code is removed that had little or no effect or was just (to my eye) in need of some updated organization.