Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mechs remain damaged after repair #584

Closed
bczretribution opened this issue Dec 29, 2017 · 12 comments
Closed

Mechs remain damaged after repair #584

bczretribution opened this issue Dec 29, 2017 · 12 comments

Comments

@bczretribution
Copy link

bczretribution commented Dec 29, 2017

Mechs sometimes are defined as having damage in the hangar screen (heavy damage, inoperable, etc. ) after having been fully repaired. inaccurate damage listing prevents their deployment in megamek. The occurrence is uncommon (3rd time so far out of several dozen salvages). Warhammer WHM-6R # 2 reserve in the attached file.
repair glitch

glitch.zip

@Flibjib
Copy link

Flibjib commented Dec 29, 2017

Have you tried saving, and restarting MekHQ? More often than not this will solve the issue. Also make sure the pilot is not injured.

@bczretribution
Copy link
Author

bczretribution commented Dec 29, 2017

I hadn't. I'll try that at the next occurrence and report back. I did try using gm mode to restore the mech.

As you can see in the image there is no pilot attached currently. The first occurrence that I noticed was even weirder though. If I put a specific uninjured pilot in an undamaged stalker they would show up in the TO&E as 3 hits to the pilot and the mech damaged. Any other combination of pilot and mech worked fine, just that particular one failed. I eventually sold the stalker to resolve the issue.

@scJazz2
Copy link

scJazz2 commented Dec 29, 2017

What version are you using? CPNX? Logs? Customs if needed?

@bczretribution
Copy link
Author

scJazz, 0.43.6, all the needed files are in the zip that was attached to the original post

@neoancient neoancient added the Bug label Jan 2, 2018
neoancient added a commit to MegaMek/megamek that referenced this issue Jan 3, 2018
Needed to track down units that are reporting damaged status though they
have no apparent damage and condition is reset on a reload.

MegaMek/mekhq#584: Mechs remain damaged after repair
@neoancient
Copy link
Member

The very nature of this type of issue makes it very difficult to track down. Since saving a reloading the campaign clears the error there is nothing in the campaign file that will help us, and it is very difficult to reproduce reliably. I have added some debugging code to MegaMek, which is where the status determination is made, to log the reason for the damaged status in hopes that knowing the reason it was flagged will help us track down the cause.

@Dylan-M
Copy link
Contributor

Dylan-M commented Feb 13, 2018

This is almost certainly some transient state that doesn't get reset after a scenario is completed, which is why save/reload clears it.

@Dylan-M Dylan-M added this to the Development 0.45 milestone Feb 13, 2018
@mkraemer67
Copy link

Just FYI this also occurs pretty frequently for me, but I am unsure what actually triggers it. It's far from uncommon though.

@HammerGS
Copy link
Member

@mkraemer67 What version are you using?

@mkraemer67
Copy link

v0.43.10 Development Snapshot (0.44 RC4)

@mkraemer67
Copy link

Actually if a mech shuts down due to heat in the last round of combat for me it is 100% reproducible that the mech stays shutdown in the first round of combat in the next battle. I'd guess that this could be related to the same issue?

@bczretribution
Copy link
Author

in a similar manner, an aerospace that is rolled at the end of a scenario is still rolled in the next scenario

@sixlettervariables
Copy link
Collaborator

It seems like this issue has not been encountered in some time, please reopen this issue if it happens again on a more recent built of MHQ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants