Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't Assign patients to doctors #91

Closed
pheonixstorm opened this issue May 28, 2016 · 9 comments
Closed

Can't Assign patients to doctors #91

pheonixstorm opened this issue May 28, 2016 · 9 comments

Comments

@pheonixstorm
Copy link
Collaborator

I have one doctor with 4 medics but can't assign my wounded to said Doctor.

Tried to hire a second doctor with the same result. Fired the medical staff and rehired the lot, advanced a day still the same. No errors show up in the log either.

@Akjosch
Copy link
Contributor

Akjosch commented May 28, 2016

Well, we'll need a campaign file, I think. At least I couldn't reproduce it.

@pheonixstorm
Copy link
Collaborator Author

Ok, will go kill some more infantry with a fresh campaign and post it

@pheonixstorm
Copy link
Collaborator Author

doctorbug.zip
mekhqlog.txt

Fresh campaign, this time w/o advanced medical and still got it to come up. Still no errors in the log.

@Akjosch
Copy link
Contributor

Akjosch commented May 29, 2016

  1. Go the the Infirmary
  2. Mark (left-click) a doctor.
  3. Mark a potential patient.
  4. Left-click "Assign" until they are all assigned.
  5. In four days, everybody is ready to be thrown back into the grinder (no clue on how realistic or close to the official wound recovery rules that is).

Well, works for me. To be fair, I don't use this tab often, so I couldn't tell if something in the way it works changed. But it does work. Weird.

@pheonixstorm
Copy link
Collaborator Author

The assign button is grayed out though and clicking it does nothing

@pheonixstorm
Copy link
Collaborator Author

I stopped being able to do anything with doctors after the changes made in #79

@pheonixstorm
Copy link
Collaborator Author

pheonixstorm commented May 29, 2016

I did find something odd but unrelated in the campaign file. Before the person endtag there is a <extraData/> tag that doesn't belong. Looks like something from the admin xp fix.

@Akjosch
Copy link
Contributor

Akjosch commented May 29, 2016

The <extraData/> part is simply a generic marker meaning "no extra data for this person". Given that patients don't reference or use that data part, it has no bearing on the infirmary either.

@Akjosch
Copy link
Contributor

Akjosch commented May 29, 2016

Playing a bit with the Infirmary, I can see two things worth fixing:

  • "Assigned Patients" scrolls horizontally while "Unassigned Patients" scrolls vertically.
  • Changing the selected doctor also changes the selection of the unassigned patients.

However, I think I found the problem (though it's strange that it doesn't hit me personally): the getSelectedUnassignedPatients() method pulls from the wrong model (the "assigned patients" one). Bundling the fixes for all of this into a PR right now.

@purpledragon2
Copy link

I think I ran into this today. let me see if I can share files...

Well, it won't allow me to upload the savegame and 7zip won't allow me to do just a good ole zip file.

mekhqlog.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants