Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infirmary cleanup #92

Merged
merged 3 commits into from May 29, 2016
Merged

Infirmary cleanup #92

merged 3 commits into from May 29, 2016

Conversation

Akjosch
Copy link
Contributor

@Akjosch Akjosch commented May 29, 2016

Cleans up all the issues and UI design problems mentioned in Bug #91 , as well as adding a separate background image for the Infirmary for additionally more distinctive UI design.

@Akjosch
Copy link
Contributor Author

Akjosch commented May 29, 2016

Not much in the way of visual changes, but a bit more distinctive now.

infirmary_2

@pheonixstorm
Copy link
Collaborator

pheonixstorm commented May 29, 2016

Like the image, but make sure it can be removed or at least optional so the image itself doesn't need to be deleted.

Also, any reason on why the personnel background isn't white in that pick?

@Akjosch
Copy link
Contributor Author

Akjosch commented May 29, 2016

Given that MekHQ has no skin editor nor the capabilities to do such, there's little I can do. At best, I can future-proof it by making the background image file name (programmatically) variable.

In doubt, delete/rename/replace it with something to your liking.

@pheonixstorm
Copy link
Collaborator

An idea, I just didn't want the thing to crash if someone deletes the image.

@Akjosch
Copy link
Contributor Author

Akjosch commented May 29, 2016

It wouldn't have crashed anyway. It would just display the default (grey) background.

@Akjosch Akjosch merged commit 56df381 into MegaMek:master May 29, 2016
@Akjosch Akjosch deleted the infirmary_cleanup branch May 29, 2016 22:12
@purpledragon2
Copy link

Love the image. Especially the background. I wish we could do something like this for the lab, warehouse and repair bays as well.

pheonixstorm pushed a commit to pheonixstorm/mekhq that referenced this pull request Jun 23, 2016
* Cleanup of the infirmary

* Making getSelectedUnassignedPatients() actually pull from the unassigned list

* Future-prooving the background image: Adding a map of gui element keys to (String) values to IconPackage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants