Mission log entries and counter for personnel #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
VicenteCartas
commented
Feb 13, 2019
VicenteCartas
commented
- Fixes Mekhq Adds # of missions partipated in counter #112 .
- Fixes bug when adding a single kill would not refresh the person view.
- Adds Log/Missions and kills to the Customize person dialog from the GM mode, so everything can be edited from the same screen. Both Dialogs and Customize use the same "control" to do their add/edit/delete operations.
- Fixes minor text issues in some of the Log/Mission/Kill dialogs.
Done: - Added new dialogs to add/edit missions. - Added new dialog to manage the mission log. - Modified PersonView to show mission information if it's present. - Save/Load mission logs when saving/loading person. Still missing: - Refresh PersonView when adding/removing missions (and kills). - Allow to edit all logs from the GM view. - Add missions when resolving scenarios (research how kills work).
Refactors Add/Edit/Delete dialogs for Logs/Missions/Kills into a control that is used from the regular dialog and from the Customize dialog.
Use ServiceLogEntry instead of MissionLogEntry.
|
Adding screenshots to show how the UI looks after the change. |
sixlettervariables
requested changes
Feb 15, 2019
Addressing PR feedback.
sixlettervariables
approved these changes
Feb 18, 2019
|
I need to open a few of the test campaigns I have from folks before merging this in. |
|
Perfect! If you want me to do the testing feel free to send me the campaign files and I'll test them. |
Old campaign files (previous to 0.45.4) will be updated to split the missions out of the personnel log into the missions log.
Cleaning version.java
More cleaning in Version.java.
Update Version.java to follow Java standards for comparables.
sixlettervariables
approved these changes
Feb 23, 2019
PR feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.