Switch to strong references instead of IDs for child parts #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sixlettervariables
requested review from
neoancient,
NickAragua and
Windchild292
Windchild292
reviewed
Oct 1, 2020
Co-authored-by: Justin Bowen <39067288+Windchild292@users.noreply.github.com>
Windchild292
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have never reliably reproduced the issues seen with child parts (such as bay doors, etc), but have always disliked our usage of IDs instead of strong references. MekHQ plays loose with IDs in order to aggregate spare parts and I'm not confident it isn't a cause of these problems.
I'm only confident this will resolve the class of errors where the part ID changed but the child part IDs were not updated.