(DRAFT) Finishing Profession Unit Testing

[Windchild292]

This is the last of the personnel enums to do

[codecov]

Codecov Report

Base: 10.67% // Head: 10.68% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (af111df) compared to base (e0f16b4).
Patch coverage: 20.00% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #3587      +/-   ##
============================================
+ Coverage     10.67%   10.68%   +0.01%     
- Complexity     5467     5478      +11     
============================================
  Files           829      829              
  Lines        113349   113349              
  Branches      17094    17094              
============================================
+ Hits          12096    12112      +16     
+ Misses       100046   100029      -17     
- Partials       1207     1208       +1     

Impacted Files	Coverage Δ
MekHQ/src/mekhq/campaign/personnel/ranks/Rank.java	49.45% <20.00%> (+2.19%)	⬆️
...src/mekhq/campaign/personnel/enums/Profession.java	89.18% <0.00%> (+18.91%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[SJuliez]

This is to not let this stew again.
I have about 0% XP on unit tests but I think I read you can prepend initialization to every test using something like @beforeall on an init method. The start of the tests looks very similar, maybe this is something to simplify, for what it's worth.

[Windchild292]

The minor differences required for the tests unfortunately make that impossible. Also, this is still a draft