Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazorise Material - First day of week #1997

Closed
danypellerin opened this issue Mar 9, 2021 · 3 comments · Fixed by #2018
Closed

Blazorise Material - First day of week #1997

danypellerin opened this issue Mar 9, 2021 · 3 comments · Fixed by #2018
Labels
Area: Material Type: Feature ⚙ Request or idea for a new feature.
Projects
Milestone

Comments

@danypellerin
Copy link

The date picker with blazorise material starts on Monday while the typical first day of week is Sunday. It should at least be configurable if it does not start on the default first day of week.

@stsrki
Copy link
Collaborator

stsrki commented Mar 10, 2021

Most of the countries use Monday as the first day of the week, including mine. And material date picker was actually one of the first components I did for Blazorise so it stuck on Monday since. I will see if how to handle it. Currently, I'm thinking of using a different date picker library that has more features.

@stsrki stsrki added this to the 0.9.4 milestone Mar 10, 2021
@stsrki stsrki added this to 🔙 Backlog in Development via automation Mar 10, 2021
@danypellerin
Copy link
Author

Most of the countries use Monday as the first day of the week, including mine. And material date picker was actually one of the first components I did for Blazorise so it stuck on Monday since. I will see if how to handle it. Currently, I'm thinking of using a different date picker library that has more features.

I would just like to clarify what I meant by the typical first day of week. :) I meant that the vast majority of date pickers default to Sunday as the first day of week, at least all of those I have used except this one. It makes sense that you made this choice at the time, I'm pretty sure the currently library you are using is flexible enough to handle a configuration but you may want to change it for other reasons. I noticed when it pops up the first time the colored area where you see the date doesn't show up.

For our specific case, the first day of week here is also Monday but our app is an extension of another product. All other date pickers start on Sunday so it's inconsistent and creates confusion. I truly appreciate you looking into this as we really like Blazorise. I may eventually start contributing to the project if you're opened to it. :)

@stsrki
Copy link
Collaborator

stsrki commented Mar 10, 2021

Yes, I understand it completely. It may be that other date pickers are better at detecting current culture and then adjust the first data accordingly.

Any help is appreciated :)

@stsrki stsrki moved this from 🔙 Backlog to 💪 In progress in Development Mar 11, 2021
@stsrki stsrki linked a pull request Mar 16, 2021 that will close this issue
@stsrki stsrki added the Type: Feature ⚙ Request or idea for a new feature. label Mar 18, 2021
@stsrki stsrki mentioned this issue Mar 18, 2021
@stsrki stsrki closed this as completed Mar 18, 2021
Development automation moved this from 💪 In progress to ✔ Done Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Material Type: Feature ⚙ Request or idea for a new feature.
Projects
Development
  
✔ Done
Development

Successfully merging a pull request may close this issue.

2 participants