Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First day of the week is incorrect #3274

Closed
ebicoglu opened this issue Dec 31, 2021 · 3 comments
Closed

First day of the week is incorrect #3274

ebicoglu opened this issue Dec 31, 2021 · 3 comments
Assignees
Labels
Type: Bug 🐞 Something isn't working
Projects

Comments

@ebicoglu
Copy link

ebicoglu commented Dec 31, 2021

Describe the bug
The first day is Tuesday which is incorrect.
Must be culture-specific or Monday.
Maybe related to #1997
image

@ebicoglu ebicoglu added the Type: Bug 🐞 Something isn't working label Dec 31, 2021
@David-Moreira
Copy link
Contributor

David-Moreira commented Dec 31, 2021

Hello @ebicoglu,
have you tried to use FirstDayOfWeek setting?
image

Edit : (Independent of FirstDayOfWeek, you are right the day is totally wrong, day 6 is a monday, even if it started on tuesday, it should be day 7)

In the meantime, I went to take a look at the translation since I knew I had seen this visually starting on Monday by default when localization is set to my native language which is Portuguese. I noticed the translations are jumbled up:
image

(Should be )

"Monday": "Segunda-feira",
"Tuesday": "Terça-feira",
"Wednesday": "Quarta-feira",
"Thursday": "Quinta-feira",
"Friday": "Sexta-feira",
"Saturday": "Sábado",
"Sunsay": "Domingo",

(I can go ahead and correct the pt translations later...)
@stsrki can you check if the same happens for other translations?

@David-Moreira David-Moreira self-assigned this Dec 31, 2021
@sturlath
Copy link
Contributor

sturlath commented Dec 31, 2021

The days are also shifted for icelandic https://github.com/Megabit/Blazorise/blob/447d4773575f1c1f2530d4189c93935ac4141133/Source/Blazorise/Resources/Localization/DatePicker/is.json

Mondays are shown as Sunday etc. I created a PR for the changes.

@stsrki
Copy link
Collaborator

stsrki commented Dec 31, 2021

Yeah, it seems it is a copy-paste mistake. We'll fix it. @David-Moreira you can fix Portuguese

@stsrki stsrki added this to 🔙 Backlog in Support via automation Dec 31, 2021
@stsrki stsrki added this to the 0.9.5 Support milestone Dec 31, 2021
This was referenced Jan 4, 2022
@stsrki stsrki closed this as completed Jan 4, 2022
Support automation moved this from 🔙 Backlog to ✔ Done Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐞 Something isn't working
Projects
Support
  
✔ Done
Development

No branches or pull requests

4 participants