Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launchSettings.json warning #248

Closed
PhilPJL opened this issue Sep 8, 2019 · 5 comments
Closed

launchSettings.json warning #248

PhilPJL opened this issue Sep 8, 2019 · 5 comments

Comments

@PhilPJL
Copy link

PhilPJL commented Sep 8, 2019

If I add blazorise to a source controlled (Azure DevOps/TFS) project then I get a warning message:

image

I get the message if launchSettings.json is or isn't already added to source control.
I haven't seen this exact issue before, but there was a similar warning when adding Tewr's filer reader component Tewr/BlazorFileReader#55 which is now fixed.

@stsrki
Copy link
Collaborator

stsrki commented Sep 9, 2019

U must say this is the first time I see this message. The only thing I can think of is to remove the launchSettings.json from NuGet package but I don't know if that will break something else. I will investigate this more and let you know.

@PhilPJL
Copy link
Author

PhilPJL commented Sep 9, 2019

That will almost certainly fix the issue. I think VS always has a launchSettings.json for any .NET core app so there probably shouldn't be one in your NuGet package.

@stsrki stsrki added the Priority: Critical ☠ Possible bug label Sep 9, 2019
@stsrki stsrki added this to Backlog in Development via automation Sep 9, 2019
@stsrki stsrki added this to the 0.8.5 milestone Sep 9, 2019
@stsrki
Copy link
Collaborator

stsrki commented Sep 9, 2019

Moving to current 0.8.5 milestone.

@stsrki stsrki moved this from Backlog to To do in Development Sep 9, 2019
@stsrki stsrki moved this from To do to In progress in Development Sep 9, 2019
@stsrki
Copy link
Collaborator

stsrki commented Sep 9, 2019

I have published a preview version to the MyGet so please try it and let me know how it works for you,

The feed url is https://www.myget.org/F/blazorise/api/v3/index.json

@PhilPJL
Copy link
Author

PhilPJL commented Sep 9, 2019

That looks good, no warning when adding the package or opening the solution.

@stsrki stsrki closed this as completed Sep 10, 2019
@stsrki stsrki moved this from In progress to Done in Development Sep 10, 2019
@stsrki stsrki mentioned this issue Sep 18, 2019
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development
  
✔ Done
Development

No branches or pull requests

2 participants