Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source control question #55

Closed
PhilPJL opened this issue Aug 5, 2019 · 10 comments
Closed

Source control question #55

PhilPJL opened this issue Aug 5, 2019 · 10 comments
Labels
packaging Problems concerning the nuget package question Further information is requested

Comments

@PhilPJL
Copy link

PhilPJL commented Aug 5, 2019

Adding your package results in

image

but the files are actually located

image

so I get this message, and I can't add them to source control

image

I can ignore the warning obviously.

@Tewr
Copy link
Owner

Tewr commented Aug 6, 2019

I'd say this is expected behavior. You normally do not want to add third-party libraries nor their static assets directly to your source control, at least if you are using nuget. Referencing them this way should work fine. as long as they are part of your solution directory structure. Edit: solution-local package folders are no longer needed / in use by visual studio with the new csproj format.

@Tewr Tewr added the question Further information is requested label Aug 6, 2019
@PhilPJL
Copy link
Author

PhilPJL commented Aug 6, 2019

Maybe, but I've never seen that warning before when using various NuGet packages on ASP.NET MVC projects.
I'll try putting my test project through the DevOps build server and see what happens when the app is deployed.

@Tewr
Copy link
Owner

Tewr commented Aug 6, 2019

Let me know if you run into any problems other than the warning. There has been some packaging issues in the past, there is no detailed documentation from the blazor side on referencing static assets and how this should ideally work with nuget

@PhilPJL
Copy link
Author

PhilPJL commented Aug 20, 2019

Nearly getting around to using your file reader. I notice this:

I don't see anything scripts or css associated with Radzen in the project

image

but when the app is deployed with Web Deploy, Radzen css and scripts end up in the wwwroot/_content folder. Your script doesn't appear.

image

@Tewr
Copy link
Owner

Tewr commented Aug 20, 2019

Thanks for the details! I've read up a tad on this and indeed, there has been some changes since preview7 that I missed on the subject. I simply need to move the files to wwwroot/_content and it should be ok. Or I should just remove it... In any case, this should certainly be adressed.

Are you having any problems (runtime / publish-time) other than that annoying message and things looking weird? In the current implementation of the package the script file should not really be needed (it's packed inside the dll). Just trying to assess the emergency... :)

@Tewr Tewr added the packaging Problems concerning the nuget package label Aug 20, 2019
@PhilPJL
Copy link
Author

PhilPJL commented Aug 20, 2019

No emergency yet. Haven't got to the point of trying to upload a file :)

@Tewr
Copy link
Owner

Tewr commented Aug 20, 2019

Wasn't as easy as I thought. I found out that the <RazorLangVersion>3.0</RazorLangVersion> element is apparently used as a marker for static assets (even if no razor is used), but other than that I am clueless on why the nuspec references my js.

I'll have to rebuild the project incrementally to find out.

@Tewr
Copy link
Owner

Tewr commented Aug 20, 2019

Apparently it was my TypeScript build who added them. Ill fix this issue in the next release. THanks for your feedback.

@PhilPJL
Copy link
Author

PhilPJL commented Aug 30, 2019

@Tewr
Hi, I don't think this is fixed. If I remove the Nuget package, FileReaderComponent.js is removed. When I add the package back I get
image

Looks like it's not just your component that this issue. A colleague has added Blazorise to the app

image

@Tewr
Copy link
Owner

Tewr commented Sep 1, 2019

You are right, problem is still there in the latest release. I managed to figure out what the error was, but as I havent automated packaging I failed to account for it when building the package in the latest release. Next release should be ok...

Thank you for tracking me on this issue or I would have missed it! Ideally I should create a test that verifies the package contents, but its a lot of work and I'm hoping it should stabilize now when approaching 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Problems concerning the nuget package question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants