Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: DataGrid batch edit SOMETIMES saves if using tab in In cell mode #5332

Closed
leetheman opened this issue Feb 27, 2024 · 4 comments · Fixed by #5343
Closed

[Bug]: DataGrid batch edit SOMETIMES saves if using tab in In cell mode #5332

leetheman opened this issue Feb 27, 2024 · 4 comments · Fixed by #5343
Assignees
Labels
Type: Bug 🐞 Something isn't working
Projects
Milestone

Comments

@leetheman
Copy link

Blazorise Version

1.4

What Blazorise provider are you running on?

Bootstrap5

Link to minimal reproduction, or a simple code snippet

You can see this for yourself in the demo:

https://blazorise.com/docs/extensions/datagrid/features/editing

If you choose incell edit, and attempt to batch edit:

  1. Using the ENTER key always works. Which is great, but it does not logically move to the next cell to the right (like Excel), so a bit annoying.
  2. Using the TAB key SOMETIMES works. But it moves to the next cell which is great.

You can test this out on the demo - change the edit type to InCell and edit a cell. If you press ENTER it will always save. IF you press TAB it will not save, until you then go back and press enter in another cell - at which point TAB will always save.

Steps to reproduce

See above

What is expected?

TAB should always save and move to the right

What is actually happening?

TAB behaviiour is inconsistent

What browsers are you seeing the problem on?

No response

Any additional comments?

No response

@leetheman leetheman added the Type: Bug 🐞 Something isn't working label Feb 27, 2024
@leetheman
Copy link
Author

Edit: apologies, TAB does not move to the right if it saves. The problem is that sometimes TAB saves the eidt, and sometimes it does not. But the ideal would be for it to save AND move to right, is that possible?

@David-Moreira
Copy link
Contributor

If I remember correctly, that's how it should work yes, we'll let you know once we have more details.

@David-Moreira David-Moreira self-assigned this Feb 27, 2024
@David-Moreira David-Moreira added this to 🔙 Backlog in Support via automation Feb 27, 2024
@David-Moreira David-Moreira moved this from 🔙 Backlog to 💪 In progress in Support Feb 27, 2024
@David-Moreira
Copy link
Contributor

@leetheman Seems to be working correctly. Am I testing incorrectly?
Can you let me know how to reproduce?

chrome-capture-2024-2-27

@leetheman
Copy link
Author

leetheman commented Feb 28, 2024 via email

@David-Moreira David-Moreira linked a pull request Mar 5, 2024 that will close this issue
@stsrki stsrki added this to the 1.4 support milestone Mar 5, 2024
@stsrki stsrki closed this as completed Mar 5, 2024
Support automation moved this from 💪 In progress to ✔ Done Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐞 Something isn't working
Projects
Support
  
✔ Done
3 participants