Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataGrid: Fix Localization FilterMethods #5475

Merged
merged 1 commit into from May 5, 2024
Merged

DataGrid: Fix Localization FilterMethods #5475

merged 1 commit into from May 5, 2024

Conversation

panmona
Copy link
Contributor

@panmona panmona commented Apr 23, 2024 •
edited

Description

  • Remove hardcoded "Filter" and "Clear Filter" localizations
  • Add custom localizers for GreaterThan, GreaterThanOrEqual, LessThan, LessThanOrEqual
  • Fix localization resource name of GreaterThanOrEqual and LessThanOrEqual
  • Add FilterMode to DataGrid demo for easier testing

Related to #5468

How Has This Been Tested?

  • Tested in Material Datagrid Demo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

  • The PR is submitted to the correct branch (master for dev, rel-1.x for maintenance).
  • My code follows the code style of this project.
  • I've added relevant tests.
    -> only tested with the Demo. Not sure how else this can be tested.

@panmona panmona changed the title Fix Localization of Datagrid FilterMethods DataGrid: Fix Localization FilterMethods Apr 23, 2024
@panmona
Fix Localization of Datagrid FilterMethods
29e0e24 
- Remove hardcoded "Filter" and "Clear Filter" localizations
- Add custom localizers for GreaterThan, GreaterThanOrEqual, LessThan,
LessThanOrEqual
- Fix localization resource name of GreaterThanOrEqual and
LessThanOrEqual
- Add FilterMode to DataGrid demo for easier testing
@David-Moreira David-Moreira self-requested a review May 5, 2024 09:26
David-Moreira
David-Moreira approved these changes May 5, 2024
View reviewed changes
Copy link
Contributor

@David-Moreira David-Moreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@David-Moreira David-Moreira requested a review from stsrki May 5, 2024 09:34
stsrki
stsrki approved these changes May 5, 2024
View reviewed changes
Copy link
Collaborator

@stsrki stsrki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. There are some small additions to the API but it shouldn't be a problem by the look of it.

@panmona thank you for the contribution.

@stsrki stsrki mentioned this pull request May 5, 2024
Open
@stsrki stsrki merged commit ce36a91 into Megabit:rel-1.5 May 5, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stsrki stsrki stsrki approved these changes

@David-Moreira David-Moreira David-Moreira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@panmona @stsrki @David-Moreira