Cart #15
Cart #15
Conversation
AYOPELUMI
commented
Jun 23, 2024
AYOPELUMI
commented
- Created the Cart Context API
- Added the Context wrapper in the 'App.jsx' file
- Moved the 'products.json' file to the public folder
- Fixed the bugs in the Product component
- Added the 'add to cart' functionality to the productCard component
- Added Cart to the routes for
AYOPELUMI
added
documentation
|
Approved.
…On Mon, Jun 24, 2024 at 12:31 AM AYOPELUMI ***@***.***> wrote:
@AYOPELUMI <https://github.com/AYOPELUMI> requested your review on: #15
<#15> Cart.
—
Reply to this email directly, view it on GitHub
<#15 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZFWDDMZVB47SCLP5R23FRTZI5LG3AVCNFSM6AAAAABJYY2WDOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGI2TQNBXGI2TSMA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
src/pages/Cart/Cart.css
Outdated
| /* Cart.css */ | ||
|
|
||
| .cart-container { | ||
| padding: 20px; | ||
| background-color: #f9f9f9; | ||
| border: 1px solid #ddd; | ||
| border-radius: 5px; | ||
| margin-bottom: 20px; | ||
| } | ||
|
|
||
| .cart-container h2 { | ||
| font-size: 1.5em; | ||
| margin-bottom: 20px; | ||
| } | ||
|
|
||
| .cart-container p { | ||
| margin: 5px 0; | ||
| } | ||
| Cart.css */ | ||
|
|
||
| .cart-container { | ||
| padding: 20px; | ||
| background-color: #f9f9f9; | ||
| border: 1px solid #ddd; | ||
| border-radius: 5px; | ||
| margin-bottom: 20px; | ||
| } | ||
|
|
||
| .cart-container h2 { | ||
| font-size: 1.5em; | ||
| margin-bottom: 20px; | ||
| } | ||
|
|
||
| .cart-container p { | ||
| margin: 5px 0; | ||
| } | ||
|
|
||
| .cart-container ul { | ||
| list-style-type: none; | ||
| padding: 0; | ||
| } | ||
|
|
||
| .cart-container li { | ||
| border-bottom: 1px solid #ccc; | ||
| margin-bottom: 10px; | ||
| padding-bottom: 10px; | ||
| } | ||
|
|
||
| .cart-container button { | ||
| margin-right: 10px; | ||
| background-color: #007bff; | ||
| color: white; | ||
| border: none; | ||
| padding: 5px 10px; | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| .cart-container button:hover { | ||
| background-color: #0056b3; | ||
| } | ||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
@AYOPELUMI
@Divinechi
@adex-badr18
Weldone, implementing the project requirements. You all agreed to use tailwind CSS for the implementation of the styles but here you went ahead to use vanilla CSS. Please kindly redo this part of the project.
There was a problem hiding this comment.
Hi @AYOPELUMI @Divinechi
Great job so far! 👏 You've done well, and you're almost there for the next project ⏭️, but there are a few issues 🐛 that you still need to work on.
Don't Worry 🙏
It's okay to have bugs in your code. 🆗 Please see this code review as an opportunity to learn practical coding skills and discover new tips that can improve your code quality 💯 and help you get even better 💼.
I will guide you on how to address these areas down below 👇.
Highlights
✅ everyone has contributed
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Have any doubt ❓
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
| @@ -0,0 +1,87 @@ | |||
| /* eslint-disable react/prop-types */ | |||
There was a problem hiding this comment.
@AYOPELUMI
Here you disabled the eslint from the project. please kindly do your implementation without disabling the eslint. the eslint helps us write good codes that are modular and obeys standards.
There was a problem hiding this comment.
Thanks for the insights
I will do that after fully pleased that all basic functionality and design layout are met
src/pages/Cart/Cart.jsx
Outdated
| import './Cart.css'; // Import the CSS file for styling | ||
|
|
There was a problem hiding this comment.
@Divinechi Please kindly style the project with Tailwind as we all agreed.
There was a problem hiding this comment.
Sure I have done that thank you, you can review it now.
|
@Divinechi I am sorry we cannot merge your work into the development branch. This is because your styling has affected the initial work carried out on the project. Have a look at the screenshot of your styles.
I have disabled the ability for anyone to merge pull requests. imagine what could have happened if this pull request is merged without review. it will just revert us to square one.
Please don't merge this pull request. |
postcss.config.cjs
Outdated
| export default { | ||
| module.exports = { | ||
| plugins: { |
There was a problem hiding this comment.
Why did you tamper with the Tailwind config? @Divinechi
There was a problem hiding this comment.
@Divinechi I am sorry we cannot merge your work into the development branch. This is because your styling has affected the initial work carried out on the project. Have a look at the screenshot of your styles.
I have disabled the ability for anyone to merge pull requests. imagine what could have happened if this pull request is merged without review. it will just revert us to square one.
Please don't merge this pull request.
Thanks
|
@iyke-e I saw the commit on tailwind config file which you pushed. This is to bring to your notice that the styling errors are not yet sorted out. Please kindly implement this. If you are having issues that you cannot solve, reach out to team members to help you get unstuck |
|
Noted we're working on it |
|
Weldone, on your awesome work. Project is approved as agreed by the reviews during the call today. congratulations |
