Fix #63 Compact Machine wall rendering, Use MixinBooter in build.gradle #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MixinBooter is required to load this mixin, but not to run Nothirium.
This was referenced Jan 27, 2024
|
Merged into ACGaming/UniversalTweaks#366 for compatibility with Vintagium as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #63 by mixing into Compact Machines, making few changes to Nothirium's existing codebase. See the latest comment in the issue for details on why this is necessary and is only exhibited with Nothirium 0.2.x+ and not older versions/vanilla.
Because this patch requires mixing into a (non-core) mod, I utilize
ILateMixinLoaderfrom MixinBooter, so MixinBooter is required for this patch to apply. I tried my best to keep compatibility with MixinBoostrap, so Nothirium should still work with either MixinBootstrap or MixinBooter, but MixinBooter is required to specifically fix the Compact Machines walls. As such, I did not include any strict checks for MixinBooter.Changes build.gradle to use MixinBooter hopefully without any issues. Also, apologies for any formatting issues.