Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Compact Machine walls are invisible #7

Closed
jchung01 opened this issue Jan 27, 2024 · 1 comment · Fixed by ACGaming/UniversalTweaks#366
Closed

Some Compact Machine walls are invisible #7

jchung01 opened this issue Jan 27, 2024 · 1 comment · Fixed by ACGaming/UniversalTweaks#366

Comments

@jchung01
Copy link

Bug Description

Compact Machine (CM) walls in a compact machine will be invisible if they are not in the lower subchunk (y<=47) of the machine. This bug is actually the same bug as Meldexun/Nothirium#63 as I assume Sodium/Vintagium also splits the blockstate data between subchunks. Yes, it is CM's fault that they aren't taking y value into account when rendering the sides, but the bug is only exhibited with such performance mods (see last comment in the Nothirium issue for more info).

I provided a fix through mixin into CM in Meldexun/Nothirium#88, so you can do what you like with that code. Please let me know if the fix would be more appropriate to include into UniversalTweaks as this is a mixin into a mod for compatibility, and I can open a PR there. I can confirm the fix works even for this mod.

Reproduction Steps

Using:

  • Compact Machines: 3.0.18-b278
  • Vintagium: build from commit b60cf92
  1. Place a Normal, Large, Giant, or Maximum Compact Machine.
  2. Enter the compact machine by right clicking it with a Personal Shrinking Device.
  3. See that the Solid Compact Machine Walls at y=48 and above are invisible.

Log File

N/A

@Asek3
Copy link
Owner

Asek3 commented Jan 28, 2024

It's better to PR the fix to the UniversalTweaks since it happens not only with Vintagium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants