chore: Enable api and manifests regeneration before testing #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10113389910Details
💛 - Coveralls |
…prior to running tests Signed-off-by: Soule BA <souleb@nvidia.com>
|
/retest-image_scan |
rollandf
reviewed
Jul 30, 2024
| @@ -271,14 +271,14 @@ setup-envtest: $(SETUP_ENVTEST) ## Install envtest binaries | |||
| clean-envtest: setup-envtest ;## Clean up assets installed by setup-envtest | |||
| $Q $(SETUP_ENVTEST) cleanup | |||
|
|
|||
| check test tests: setup-envtest ; $(info running $(NAME:%=% )tests...) @ ## Run tests | |||
| check test tests: tidy generate fmt vet manifests setup-envtest ; $(info running $(NAME:%=% )tests...) @ ## Run tests | |||
There was a problem hiding this comment.
Do we really need to run these on make test? Won't it make running tests locally longer?
Maybe we should have build check that tidy/fmt/vet/generate are passing without any file changes, in the same manner as we have for manifests?
Here is the check for manifests: https://github.com/Mellanox/network-operator/blob/master/.github/workflows/build.yml#L52
There was a problem hiding this comment.
time wise this is trivial compared to envtest setup and actual tests. My idea is to make sure that locally running test gives me the best possible confidence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to enable
fmt/vetas well as updating module and regeneratingapisandmanifestsin an automated manner as part of running tests targets.