feat: MOFED subscription mounts #946
Conversation
rollandf
added
the
on hold
Pull Request Test Coverage Report for Build 9208587816Details
💛 - Coveralls |
|
Related Red Hat Knowledgebase : https://access.redhat.com/solutions/5870841 |
| @@ -127,6 +129,8 @@ func (p *provider) GetNodePools(filters ...Filter) []NodePool { | |||
| } | |||
| nodePool.Kernel = kernel | |||
|
|
|||
| nodePool.ContainerRuntime = getContainerRuntime(node) | |||
There was a problem hiding this comment.
do you assume that container runtime is the same for all nodes that are part of the pool ?
technically every attribute that is not part of the key in nodePoolMap may be different and you just save the last node that match.
There was a problem hiding this comment.
Yes, I assume all nodes in the same pool have the same container runtime.
There was a problem hiding this comment.
ack. technically i think we can have several runtimes. moreover it can be set dynamically with RuntimeClass[1] but i dont think we have a requirement to support it.
[1] https://kubernetes.io/docs/concepts/containers/runtime-class/
| func (s *stateOFED) handleSubscriptionVolumes( | ||
| ctx context.Context, osname string, runtime string, mounts *additionalVolumeMounts) error { | ||
| reqLogger := log.FromContext(ctx) | ||
| if osname == "rhel" && runtime != nodeinfo.CRIO { |
There was a problem hiding this comment.
do we want to ignore an empty runtime value ?
There was a problem hiding this comment.
Can an empty runtime happen?
There was a problem hiding this comment.
field should be set. just wondering if we should add check for completness.
Add needed mounts for subscription in RHEL with non CRIO container runtime. Signed-off-by: Fred Rolland <frolland@nvidia.com>
|
/retest-image_scan |
|
/retest-nic_operator_helm |
rollandf
removed
the
on hold
|
Tested manually on cluster with RHEL 8.8, containerd 1.7.16 |
Add needed mounts for subscription in RHEL with non CRIO container runtime.