Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recursive folder scan #129

Merged
merged 4 commits into from
Mar 24, 2023

Conversation

TyShkan
Copy link
Contributor

@TyShkan TyShkan commented Mar 24, 2023

Closes #128

Fixes description in meltano.yml (file → path)

tap_csv/client.py Outdated Show resolved Hide resolved
@pnadolny13
Copy link
Collaborator

pnadolny13 commented Mar 24, 2023

@TyShkan this looks great! I ran it locally and added a test to confirm it worked as expected so I opened a PR to your branch with that new test TyShkan#1. If you pull that in then I think we're good to merge this!

@@ -22,10 +22,10 @@ plugins:
add_metadata_columns: false
settings:
- name: files
description: Array of objects containing keys - `entity`, `file`, `keys`, `encoding` (Optional), `delimiter` (Optional), `doublequote` (Optional), `escapechar` (Optional), `quotechar` (Optional), `skipinitialspace` (Optional), `strict` (Optional)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TyShkan good catch!

add test for recursively getting files
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TyShkan
Copy link
Contributor Author

TyShkan commented Mar 24, 2023

Looks like we are good to go!

Copy link
Collaborator

@pnadolny13 pnadolny13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TyShkan great work, thanks for fixing this!

@pnadolny13 pnadolny13 merged commit e241c09 into MeltanoLabs:main Mar 24, 2023
@TyShkan TyShkan deleted the fix_recursive_folder_scan branch March 24, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bug / add feature for recursive folder scan
2 participants