-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement i18next and add some example translations including german #588
Conversation
Great! I also thought about requesting that. Thanks! In our project (jamulus.io) we use a web app for easier translation by the community. We use Hosted Weblate but I think there are others too. |
@ann0see yeah I could see that in the future as i18next has support for that but 1 thing after another 😁 |
This is great. Holding off on merging as you requested. |
# Conflicts: # ios/Podfile.lock # package.json
# Conflicts: # package.json
@Felix-Staud Let me know whenever you think this is good to go. I tested it and it seems great! |
…86-i18n # Conflicts: # src/components/common/Comments/CommentBody.tsx # src/components/screens/Onboarding/OnboardingIndexScreen.tsx
# Conflicts: # src/components/screens/Settings/Account/EditAccountScreen.tsx # src/components/screens/Settings/Account/ViewAccountsScreen.tsx
@gkasdorf It's now ready to be merged. |
PR Creator Checklist
Ensure you've checked the following before submitting your PR:
Summary
It adds a general internationalisation (i18n) implementation that can be extended to the whole application. For now I've only translated a bit (english and german) for presentational purposes
Screenshots
Test Plan
fixes #586