Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding Community service and community mod list #678

Merged
merged 10 commits into from
Jul 17, 2023
Merged

adding Community service and community mod list #678

merged 10 commits into from
Jul 17, 2023

Conversation

bohn002
Copy link
Contributor

@bohn002 bohn002 commented Jul 15, 2023

PR Creator Checklist

Ensure you've checked the following before submitting your PR:

  • You've discussed making your changes with a member of the dev team per contributing rules in the README
  • Your changes are free of any lint errors
  • Your changes are free of any typescript errors
  • You've tested your changes

Summary

Please provide a summary of what your PR does

Screenshots

If the UI has been changed, include screenshots.
We will not review your PR without screenshots if they are applicable.

Test Plan

Please documemnt the steps required to test your PR

@gkasdorf gkasdorf linked an issue Jul 15, 2023 that may be closed by this pull request
Build Community Query #653
Closed
@bohn002
Copy link
Contributor Author

bohn002 commented Jul 15, 2023

With "Show instance names for Usernames":
image
image

Without:
image
image

Also resolves #547

@bohn002 bohn002 marked this pull request as ready for review July 15, 2023 19:13
gkasdorf
gkasdorf requested changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@gkasdorf gkasdorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just those two things, otherwise looks good.

@gkasdorf gkasdorf merged commit 84e3e17 into Memmy-App:main Jul 17, 2023
3 checks passed
@bohn002 bohn002 deleted the community_query branch July 17, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkasdorf gkasdorf gkasdorf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build Community Query
2 participants
@bohn002 @gkasdorf