Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

647 show hide read button #723

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

joshua-davis-rose
Copy link
Contributor

PR Creator Checklist

Ensure you've checked the following before submitting your PR:

  • You've discussed making your changes with a member of the dev team per contributing rules in the README
  • Your changes are free of any lint errors
  • Your changes are free of any typescript errors
  • You've tested your changes

Summary

Please provide a summary of what your PR does

This addresses #647 . Details of implementation deviating from the ticket description were discussed with @ktgd .

Adds a Show Hide Read Button setting to enable/disable the visibility of the Hide Read FAB. Included a footer detailing what the Hide Read Posts on Feed and Show Hide Read Button settings do.

Screenshots

If the UI has been changed, include screenshots.
We will not review your PR without screenshots if they are applicable.

Simulator Screenshot - iPhone 14 Pro Max - 2023-07-17 at 09 06 04

Test Plan

Please documemnt the steps required to test your PR

  1. View the feed as normal. Any read posts should remain visible after refreshing the feed.
  2. Enable the Hide Read Posts on Feed setting. Repeat step 1. Now any read posts should disappear on refreshing of the feed, but the Eye FAB should not appear.
  3. Enable the Show Hide Read Button. Returning to the feed should now show the Eye FAB button. After reading posts, pressing the FAB should remove read posts from the feed without refresh.

Copy link
Collaborator

@sgriff96 sgriff96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this

@sgriff96 sgriff96 merged commit bcb3709 into Memmy-App:main Jul 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants