Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#600 fix total score #854

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

flx-sta
Copy link
Contributor

@flx-sta flx-sta commented Jul 26, 2023

PR Creator Checklist

Ensure you've checked the following before submitting your PR:

  • You've discussed making your changes with a member of the dev team per contributing rules in the README
  • Your changes are free of any lint errors
  • Your changes are free of any typescript errors
  • You've tested your changes

Summary

Make use of <VoteData ..../> everywhere else so displayTotalScore applies to those displays too.
fixes #600

Screenshots

imageimageimageimage

Test Plan

  1. Go to settings > Appearance and make sure you have display total score active
    • image
  2. Go back to Feed
  3. Check if you only see the final voting score of a feed item/post
  4. Change the view to compact (top right 3 dots post size - compact)
  5. You should only see the total score
  6. Go inside a post with comments
  7. check that the comments only display final score (including the replies)
  8. Go to your profile
  9. Check your comments/post/saved posts
  10. They should also only display the total score

make total score apply everywhere
@gkasdorf gkasdorf merged commit 1c985e2 into Memmy-App:main Jul 27, 2023
3 checks passed
@flx-sta flx-sta deleted the feature/600-total-score-everywhere branch July 27, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply „Display total score“ option everywhere
2 participants