Skip to content

Commit

Permalink
Cleaning up not useful TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
MeoMix committed May 18, 2015
1 parent 4c207d0 commit 53e626d
Show file tree
Hide file tree
Showing 9 changed files with 4 additions and 9 deletions.
2 changes: 1 addition & 1 deletion src/js/background/collection/streamItems.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
},

addSongs: function(songs, options) {
// TODO: reduce cyclomatic complexity.
// TODO: Reduce cyclomatic complexity.
/* jshint ignore:start */
options = _.isUndefined(options) ? {} : options;
songs = songs instanceof Backbone.Collection ? songs.models : _.isArray(songs) ? songs : [songs];
Expand Down
2 changes: 1 addition & 1 deletion src/js/background/model/dataSource.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
url: ''
},

// TODO: Function is way too big
// TODO: Reduce cyclomatic complexity
// Take the URL given to the dataSource and parse it for relevant information.
// If the URL is for a Playlist -- just get the title and set the ID. If it's a Channel,
// need to fetch the Channel's Uploads playlist first.
Expand Down
1 change: 0 additions & 1 deletion src/js/foreground/model/selectionBar/selectionBar.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
this.on('change:activeCollection', this._onChangeActiveCollection);
this.listenTo(signInManager, 'change:signedInUser', this._onSignInManagerChangeSignedInUser);

// TODO: Make bindEntityEvents a part of BB model
Marionette.bindEntityEvents(this, this.get('streamItems'), this.streamItemsEvents);
},

Expand Down
2 changes: 1 addition & 1 deletion src/js/foreground/view/behavior/listItemButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@
_debounceOnClickAction: null,

_doOnClickAction: function() {
// TODO: Prefer not to check hasClass and leverage state of a model.
if (!this.$el.hasClass('is-disabled')) {
// TODO: This should probably be a triggerMethod?
this.view.doOnClickAction();
}
}
Expand Down
1 change: 0 additions & 1 deletion src/js/foreground/view/behavior/scrollable.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
this._updateScrollbar();
},

// TODO: This wouldn't be necessary (and bad) if I calculate the height of the view before sliding it out and use transforms.
onListHeightUpdated: function() {
requestAnimationFrame(this._updateScrollbar.bind(this));
},
Expand Down
2 changes: 1 addition & 1 deletion src/js/foreground/view/behavior/slidingRender.js
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
},

_setRenderedElements: function(scrollTop) {
// TODO: Clean this up. It's still such a huge function.
// TODO: Reduce cyclomatic complexity
/* jshint ignore:start */
// Figure out the range of items currently rendered:
var currentMinRenderIndex = this.minRenderIndex;
Expand Down
1 change: 0 additions & 1 deletion src/js/foreground/view/dialog/createPlaylistView.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
var CreatePlaylistView = Marionette.LayoutView.extend({
id: 'createPlaylist',
template: _.template(CreatePlaylistTemplate),
// TODO: Would also be nice to pull this from the DB instead, need to truncate DB column to 150.
titleMaxLength: 150,

templateHelpers: function() {
Expand Down
1 change: 0 additions & 1 deletion src/js/foreground/view/dialog/dialogRegion.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
// http://developer.chrome.com/extensions/runtime#method-requestUpdateCheck
_showDialogIfUpdateAvailable: function() {
// Calling requestUpdateCheck will cause onUpdateAvailable to trigger if an update is available.
// TODO: Check if the response is 'throttled' and, if so, wait 5 seconds and try again. Potentially use exponential back-off instead of linear 5s.
chrome.runtime.requestUpdateCheck(_.noop);
},

Expand Down
1 change: 0 additions & 1 deletion src/js/foreground/view/dialog/editPlaylistView.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
var EditPlaylistView = Marionette.LayoutView.extend({
id: 'editPlaylist',
template: _.template(EditPlaylistTemplate),
// TODO: Not DRY w/ CreatePlaylistView -- pull from DB?
titleMaxLength: 150,

templateHelpers: function() {
Expand Down

0 comments on commit 53e626d

Please sign in to comment.