Patching #404

src/js/background/main.js

@@ -18,6 +18,12 @@
 define(['../common/requireConfig'], function() {
     'use strict';
 
-    //  Then, load all of the plugins needed by the background:
-    require(['background/plugins']);
+    //  Opening background.html into its own tab causes the program to work incorrectly for a multitude of reasons.
+    //  Prevent this by detecting the background being open outside of its default usage.
+    if (document.location.pathname === '/background.html' && window !== chrome.extension.getBackgroundPage()) {
+        window.close();
+    } else {
+        //  Then, load all of the plugins needed by the background:
+        require(['background/plugins']);
+    }
 });

src/js/background/model/youTubePlayer.js

@@ -129,6 +129,8 @@
 
         //  Emit errors so the foreground so can notify the user.
         _onYouTubePlayerError: function(error) {
+            //  TODO: YouTube's API emits a 'ReallyBad' error when it really wants to emit an 'NoPlayEmbedded2' error due to content restrictions.
+            //  This only happens if I have the Referer set to a YouTube domain, though. Otherwise, it gives the correct error message.
             //  If the error is really bad then attempt to recover rather than reflecting the error throughout the program.
             if (error.data === YouTubePlayerError.ReallyBad) {
                 this.preload();

src/js/background/view/youTubePlayerView.js

@@ -55,6 +55,7 @@
         //  Without a Referer - YouTube will reject most requests to play music.
         _onChromeWebRequestBeforeSendHeaders: function(info) {
             var refererRequestHeader = this._getHeader(info.requestHeaders, 'Referer');
+            //  TODO: I think it would be prudent to set the referer to this.el.src
             var referer = 'https://www.youtube.com/';
 
             if (_.isUndefined(refererRequestHeader)) {

src/js/common/enum/youTubePlayerError.js

@@ -5,7 +5,7 @@
 define({
     None: -1,
     InvalidParameter: 2,
-    //  Undocumented error that YouTube throws when it breaks due to internet issues.
+    //  Undocumented error that YouTube throws when it breaks due to internet issues and other unforseen circumstances.
     ReallyBad: 5,
     VideoNotFound: 100,
     NoPlayEmbedded: 101,