Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate boardgame.io turns #10

Closed
seanprashad opened this issue Nov 9, 2018 · 6 comments
Closed

Integrate boardgame.io turns #10

seanprashad opened this issue Nov 9, 2018 · 6 comments
Labels
contrib:assigned 🆘 This issue has been assigned to a contributor enhancement 🌈 New feature or request help wanted 🙏🏼 Extra attention is needed

Comments

@seanprashad
Copy link
Contributor

With #8 landing, we can take it a step further to integrate turn orders from boardgame.io.

What we aim to do is have one player enter text in a chatbox while the other is disabled. Once that same player has finished writing and added their text, focus should switch to the second player.

@seanprashad seanprashad added enhancement 🌈 New feature or request help wanted 🙏🏼 Extra attention is needed labels Nov 9, 2018
@tienpv222
Copy link

I'll give this a shot if no one takes it

@seanprashad
Copy link
Contributor Author

Great @pynnl!

We should look to enable the textbox for player one initially (think of them as the story creator). Textbox two should only be enabled after player one has sent their message (and vice versa).

Please don't hesitate to let us know if you have any questions - reach out to us here or on our Slack!

@seanprashad seanprashad added the contrib:assigned 🆘 This issue has been assigned to a contributor label Nov 10, 2018
@dnguneratne
Copy link
Contributor

I've been looking in to this for the past few days and I have a WIP PR I can open. @pynnl lets work on this together.

@seanprashad
Copy link
Contributor Author

@dnguneratne We're happy to have a work in progress PR - Prefixing it with [WIP] would let the maintainers know that it's still being worked on. It would be great to see you and @pynnl team up for this!

Please let us know if there's any questions on what a possible solution for this issue might look like 🔎

@tienpv222
Copy link

I've been looking in to this for the past few days and I have a WIP PR I can open. @pynnl lets work on this together.

Yeah just checked out your PR, it's pretty cool and exactly what I'm thinking

@seanprashad
Copy link
Contributor Author

With #20 merged into master, this can now be closed! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contrib:assigned 🆘 This issue has been assigned to a contributor enhancement 🌈 New feature or request help wanted 🙏🏼 Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants