Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #7: Add text editors and create a test page with new editors. #8

Merged
merged 6 commits into from
Nov 9, 2018
Merged

Conversation

vldmrkl
Copy link
Collaborator

@vldmrkl vldmrkl commented Nov 9, 2018

This PR contains a fix for issue #7.

It adds a new dependency React-Quill, which is a Text editor React component.

I've also created a test page under CreativeCollab.jsx component, where I placed two text editors and one kind of result container.

Here is how it looks:
cc

Copy link
Contributor

@seanprashad seanprashad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this @klymenkoo - great stuff! There are a few baby nits to fix but I tested it locally and didn't have any problems whatsoever:

creative-collab-react-quill

From here, we can open up a few new issues to help other new contributors polish up the code (and maybe add tests!).

src/CreativeCollab.css Outdated Show resolved Hide resolved
src/CreativeCollab.jsx Outdated Show resolved Hide resolved
src/TextEditor.jsx Outdated Show resolved Hide resolved
src/CreativeCollab.jsx Outdated Show resolved Hide resolved
@seanprashad seanprashad self-requested a review November 9, 2018 02:45
Copy link
Contributor

@seanprashad seanprashad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast turnaround - I'd say 🚢 it but let's wait and see if @Mera-Gangapersaud has any additional comments or questions 👩🏽

Copy link
Owner

@Mera-Gangapersaud Mera-Gangapersaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job @klymenkoo setting up text editors. This does not use the boardgame.io framework but we can tackle that in other issues. Also note that the story container does not scroll and therefore we have to scroll the whole page to see a full story if it gets too long. Again this is fine for now and will be address in another issue.

edit

@Mera-Gangapersaud Mera-Gangapersaud merged commit 03bde49 into Mera-Gangapersaud:master Nov 9, 2018
@seanprashad seanprashad mentioned this pull request Nov 9, 2018
seanprashad pushed a commit that referenced this pull request Nov 9, 2018
…ors. (#8)

* Add react-quill dependency

* Create TextEditor component using react-quill

* Create page with editors

* Make page with editors default

* Add newline at EOF

* Refactor updateStory function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌈 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants