delete tenFHcorr and merge it into wlr
#103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanxstats
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
I applied some style fixes following the tidyverse style guide.
The internal function probably needs a non-placeholder name than foo. Also, defining functions within functions (nested functions) is allowed in R, but it's generally not recommended for several reasons: lower performance (each time the outer function is called, the inner function is redefined), confusion in lexical scope and variable shadowing, and decreased maintainability as the inner function is only callable within the outer function.
However, this can be a tomorrow problem, so I will let it pass this time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.