Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

265 Summarize sim_gs_n #268

Merged
merged 24 commits into from
Aug 22, 2024
Merged

265 Summarize sim_gs_n #268

merged 24 commits into from
Aug 22, 2024

Conversation

LittleBeannie
Copy link
Collaborator

No description provided.

@LittleBeannie LittleBeannie added the development New feature or request label Jul 29, 2024
@LittleBeannie LittleBeannie self-assigned this Jul 29, 2024
@LittleBeannie LittleBeannie linked an issue Jul 29, 2024 that may be closed by this pull request
Summarize group sequential simulations #265
Closed
@LittleBeannie LittleBeannie marked this pull request as draft July 29, 2024 21:19
@LittleBeannie LittleBeannie marked this pull request as ready for review August 2, 2024 13:43
jdblischak
jdblischak requested changes Aug 5, 2024
View reviewed changes
R/sim_gs_n.R Show resolved Hide resolved
nanxstats
nanxstats reviewed Aug 6, 2024
View reviewed changes
R/global.R Outdated Show resolved Hide resolved
jdblischak
jdblischak reviewed Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@jdblischak jdblischak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is a great candidate to use the "Squash and Merge" feature with a single informative commit like "Add as_gt() and summary() methods for simtrial_gs_wlr"

DESCRIPTION Outdated Show resolved Hide resolved
R/as_gt.R Show resolved Hide resolved
R/as_gt.R Outdated Show resolved Hide resolved
R/sim_gs_n.R Show resolved Hide resolved
R/summary.R Show resolved Hide resolved
jdblischak
jdblischak approved these changes Aug 22, 2024
View reviewed changes
R/as_gt.R Show resolved Hide resolved
@LittleBeannie LittleBeannie merged commit 92cb52a into main Aug 22, 2024
7 checks passed
@LittleBeannie LittleBeannie deleted the 265-summarize-group-sequential-simulations branch August 22, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanxstats nanxstats nanxstats left review comments

@keaven keaven keaven approved these changes

@jdblischak jdblischak jdblischak approved these changes

Assignees

@LittleBeannie LittleBeannie

Labels
development New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Summarize group sequential simulations
4 participants
@LittleBeannie @nanxstats @keaven @jdblischak