Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few minor updates to fix NOTEs from R CMD check #274

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

jdblischak
Copy link
Collaborator

Yesterday I noticed a few NOTEs from R CMD check

In R-Devel, there is a new NOTE about missing package anchors:

* checking Rd cross-references ... NOTE
Found the following Rd file(s) with Rd \link{} targets missing package
anchors:
  rmst.Rd: Surv
Please provide package anchors for all Rd \link{} targets not in the
package itself and the base packages.

Since we are using the roxygen2 markdown syntax, our only option to add the package anchor is [survival::Surv()], which is awkward for the sentence, so I rearranged the link (in direct Rd syntax we could have used \code{\link[survival]{Surv}} to add the package anchor while still only displaying Surv).

I also updated the global variables that were renamed recently in #267 to fix the following NOTE:

Undefined global functions or variables:
  event_total event_trt n_risk_total

@jdblischak jdblischak self-assigned this Aug 9, 2024
@jdblischak
Copy link
Collaborator Author

Confirmed no more NOTEs from the R-Devel R CMD check

Copy link
Collaborator

@LittleBeannie LittleBeannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you, @jdblischak, for cleaning the notes!

@LittleBeannie LittleBeannie merged commit b2b431c into Merck:main Aug 9, 2024
7 checks passed
@jdblischak jdblischak deleted the r-cmd-check branch August 9, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants