Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflict condition #449

Closed
edahlseng opened this issue Jul 15, 2019 · 1 comment · Fixed by #496
Closed

Conflict condition #449

edahlseng opened this issue Jul 15, 2019 · 1 comment · Fixed by #496
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@edahlseng
Copy link
Contributor

Would it be possible to add a boolean attribute of whether there are merge conflicts in a PR? That could be used to add certain reviewers or assignees, for example.
@sileht
Copy link
Member

sileht commented Jul 16, 2019

I think we can easily expose this. Github API have an attribute called mergeable_state that can take the value "conflict". We don't want to expose this attribute directly because it's a complicated beast (and some state have some issue).

Exposing a boolean when this field is set to "conflict" looks good to me.

@sileht sileht added the enhancement New feature or request label Jul 16, 2019
@jd jd added the good first issue Good for newcomers label Jul 16, 2019
@sileht sileht mentioned this issue Sep 16, 2019
Merged
@mergify mergify bot closed this as completed in #496 Sep 17, 2019
mergify bot pushed a commit that referenced this issue Sep 17, 2019
@sileht @mergify
pr attribute: add conflict boolean
7d612c1 
Closes: #449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pr attribute: add conflict boolean
3 participants
@jd @sileht @edahlseng