Fix python CI crash in mergin-py-client #184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In mergin-py-client we're getting segfaults in CI with the new geodiff release:
GDB further points to GEODIFF_CE_newValue() function.
It looks like in geodifflib.py, few C functions didn't get arguments updated when contexts were added in #172 - with
GEODIFF_CE_newValue
being one of them. On my local machine there's no segfault, so I can't properly verify the fix (but there's nothing else looking suspicious there).Also:
column_is_pkey
in changeset reader test