Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Geodiff Context #172

Merged
merged 2 commits into from
Jun 6, 2022
Merged

Add Geodiff Context #172

merged 2 commits into from
Jun 6, 2022

Conversation

PeterPetrik
Copy link
Contributor

@PeterPetrik PeterPetrik commented May 31, 2022

fix #136

!! API BREAK !!

Introduces new Geodiff Context, currently only having logger instance. All the C-API is now changed!

  • you need to create context, and at the end DELETE it
  • all functions takes context as first argument

Also temporary we have less error logs from sqlite (no global callback), we need to implement more detailed sqlite3 logging on various places instead (#135)

@PeterPetrik PeterPetrik changed the title add Context & Logger WIP: add Context & Logger May 31, 2022
@PeterPetrik PeterPetrik changed the title WIP: add Context & Logger Add Geodiff Context Jun 2, 2022
@PeterPetrik PeterPetrik requested a review from alexbruy June 2, 2022 12:39
Copy link
Contributor

@alexbruy alexbruy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok for me, but I'm not very familiar with geodiff and might miss some details.

@PeterPetrik PeterPetrik merged commit cf32f8a into master Jun 6, 2022
@PeterPetrik PeterPetrik deleted the iss_136_context branch June 6, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it safe to use multiple geodiff instances at once
2 participants